From: Shawn O. Pearce <spearce@spearce.org>
Date: Mon, 18 Aug 2008 05:46:00 GMT
Subject: Re: [JGIT PATCH] On error in DirCache.lock, do not leave the index locked.
Message-ID: <20080818054600.GA7376@spearce.org>
In-Reply-To: <1218922587.30527.2.camel@isidore.myhome.westell.com>

"John J. Franey" <jjfraney@gmail.com> wrote:
> After using C git on the same repository, the jgit cache read
> threw an EOFException, and left the index lock file.
> The repository is still valid according to C git, but
> unreachable by C git because it honors the lock file
> left behind by jgit.

Urgh.  Thanks for the patch.
 
>  The reason for the EOFException is beyond me right now.  It
>  reported "Short read of block."  However, I'm pretty sure
>  leaving the lock file in place is an error.

If you can reproduce it, I'd like to see a copy of the index file
if that is possible.  I was pretty certain DirCache honors the
index file format properly, but a short read of a block suggests
we misread a length field somewhere.
 
-- 
Shawn.