From: Stephan Beyer <s-beyer@gmx.net>
Date: Mon, 11 Aug 2008 21:46:39 GMT
Subject: Re: [PATCH] builtin-revert: Make use of merge_recursive()
Message-ID: <20080811214639.GA28340@leksak.fem-net>
In-Reply-To: <1218491096-28756-1-git-send-email-s-beyer@gmx.net>

Sorry, I forgot to change this to [PATCH v2] or something.

And...

Stephan Beyer wrote:
> diff --git a/merge-recursive.h b/merge-recursive.h
> index f37630a..a9eead3 100644
> --- a/merge-recursive.h
> +++ b/merge-recursive.h
> @@ -1,6 +1,8 @@
>  #ifndef MERGE_RECURSIVE_H
>  #define MERGE_RECURSIVE_H
>  
> +extern struct commit *make_virtual_commit(struct tree *tree,
> +					  const char *comment);
>  int merge_recursive(struct commit *h1,
>  		    struct commit *h2,
>  		    const char *branch1,

Is this a mistake that some forward declarations in header files are not
declared "extern"?

Regards,
  Stephan

-- 
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F