From: Miklos Vajna <vmiklos@frugalware.org>
Date: Mon, 11 Aug 2008 16:46:31 GMT
Subject: Re: [PATCH 1/2] merge-recursive: prepare merge_recursive() to be called from builtins
Message-ID: <20080811164631.GK18960@genesis.frugalware.org>
In-Reply-To: <20080811151303.GA11208@leksak.fem-net>

On Mon, Aug 11, 2008 at 05:13:03PM +0200, Stephan Beyer <s-beyer@gmx.net> wrote:
> Hmm, I have the long-run vision that we have a nice libgit some day,

That would be nice, but in that case I would start avoiding die() which
is an awful amount of work... (There were multiple threads on the list
previously.)

> with merge_recursive() being part of it.  And I'm a little unsure if
> libified functions should rely on environment variables.

Well, many libs do this. Random example: ld.so relies on LD_LIBRARY_PATH
as well.

Anyway sure, using function parameters instead of env vars is more
elegant.