From: Karl Hasselström <kha@treskal.com>
Date: Sat, 09 Aug 2008 10:00:49 GMT
Subject: Re: [PATCH 2/3] Teach git diff-tree --stdin to diff trees
Message-ID: <20080809100049.GB10804@diana.vm.bytemark.co.uk>
In-Reply-To: <20080808214523.GA31424@sigill.intra.peff.net>

On 2008-08-08 17:45:23 -0400, Jeff King wrote:

> Hmm. Just looking at this as a git user, I would have expected it to
> take one or more hashes, separated by spaces. If only one, then it
> must be a commit, and it is diffed against its parents. If more than
> one, then each must be a tree-ish. So you could diff a commit
> against a tree (or a tag against a commit, or...).

I agree.

> And I think it might even be easier to code. ;)

Not for someone who's almost entirely unfamiliar with the git API.
Finding the right functions to call takes a lot of time ... which is
why I decided to chicken out and implement only the subset I actually
needed. But it can be added later -- perhaps by me.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle