From: Jeff King Date: Fri, 08 Aug 2008 13:19:33 GMT Subject: Re: git diff/log --check exitcode and PAGER environment variable Message-ID: <20080808131933.GB19705@sigill.intra.peff.net> In-Reply-To: <20080808131759.GA19705@sigill.intra.peff.net> On Fri, Aug 08, 2008 at 09:17:59AM -0400, Jeff King wrote: > Yes, all of his testing with "git diff" is hampered by the pager hiding > the exit code. And that is dealt with by the patches in next (and I > tested his examples with 'next', and they work fine). > > But that still leaves the part about "git log" not changing its exit > code. I don't think it has ever been designed to, and I'm not even sure > what the semantics would be (exit code != 0 if any logged commit has a > whitespace problem? That seems the most logical, and it might be useful > for limited ranges). ...and then after writing this I realized that all of this was dealt with later in the thread. Sorry for the noise. -Peff