From: Jeff King <peff@peff.net>
Date: Fri, 08 Aug 2008 13:17:59 GMT
Subject: Re: git diff/log --check exitcode and PAGER environment variable
Message-ID: <20080808131759.GA19705@sigill.intra.peff.net>
In-Reply-To: <7vfxpfet8a.fsf@gitster.siamese.dyndns.org>

On Fri, Aug 08, 2008 at 02:44:37AM -0700, Junio C Hamano wrote:

> "Peter Valdemar Mørch (Lists)"  <4ux6as402@sneakemail.com> writes:
> 
> > There is this old thread:
> > "[PATCH 1/5] "diff --check" should affect exit status"
> > http://thread.gmane.org/gmane.comp.version-control.git/68145/focus=68148
> > which seemed not to reach a conclusion.
> 
> Conclusion was (1) if you really care about the exit code, do not use
> pager; (2) after 1.6.0 we will swap the child/parent between git and pager
> to expose exit code from us, but not before.
> 
> Or am I mistaken?

Yes, all of his testing with "git diff" is hampered by the pager hiding
the exit code. And that is dealt with by the patches in next (and I
tested his examples with 'next', and they work fine).

But that still leaves the part about "git log" not changing its exit
code. I don't think it has ever been designed to, and I'm not even sure
what the semantics would be (exit code != 0 if any logged commit has a
whitespace problem? That seems the most logical, and it might be useful
for limited ranges).

-Peff