From: Simon Hausmann Date: Tue, 05 Aug 2008 08:24:22 GMT Subject: Re: [PATCH] git-p4: chdir now properly sets PWD environment variable in msysGit Message-ID: <200808051031.00121.simon@lst.de> In-Reply-To: <7v7iaxu7i1.fsf@gitster.siamese.dyndns.org> On Sunday 03 August 2008 23:13:42 Junio C Hamano wrote: > "Robert Blum" writes: > > P4 on Windows expects the PWD environment variable to be set to the > > current working dir, but os.chdir in python doesn't do that by default > > Missing full stop at the end of sentence aside, this comment makes me > wonder if there is an optional way to have it set it, as opposed to the > inconvenient way it behaves "by defualt". If there is none, I think your > patch, even though it looks ugly, is the least evil approach. Another way > might be to wrap callsites of system() by introducing a "run_p4" function, > like: > > def run_p4(arg): > os.environ['PWD'] = os.getcwd() if os.name == 'nt' > return system(arg) > > > --- > > > > Pushing it out to the list since I'm not entirely sure who the git-p4 > > owner even is. CC'ed likely suspects for ownership ;) > > Thanks. I've been waiting for an Ack from somewhere or success reports > from p4 users on Windows. Acked-by: Simon Hausmann It may not be the prettiest solution, but I agree it needs to be solved :) Simon