From: Johan Herland Date: Sun, 03 Aug 2008 23:47:16 GMT Subject: Re: [PATCH 0/5] Fix 'url.*.insteadOf' for submodule URLs Message-ID: <200808040147.16797.johan@herland.net> In-Reply-To: On Monday 04 August 2008, Johannes Schindelin wrote: > On Mon, 4 Aug 2008, Johan Herland wrote: > > As suggested in a thread some time ago, one could redefine the URL used > > to fetch submodules by adding a 'url.*.insteadOf' rule prior to the > > first invocation of 'git submodule update'. > > If I suggested it, but forgot the "--global" flag to "git config", I > apologize. Does this mean that you don't agree with the rationale for this patch? I.e. that submodule URLs should not be rewritten according to the rules in the super-repo (but instead require such rules to be set in the user's global config)? There are (at least) two reasons for why I think this should work without having to use '--global': 1. Consistency: Other git commands in the supermodule does _not_ require the URL rewriting rule to reside in the global config. Why should 'git submodule' be different. 2. I believe there are valid use cases for adding URL rewriting rules to the repo config instead of the global config. You may want to check out Fred's version of project X (including submodules), without making your other clones of project X start cloning/fetching from Fred. Puzzled, ...Johan -- Johan Herland, www.herland.net