From: Petr Baudis Date: Sun, 03 Aug 2008 13:20:50 GMT Subject: Re: [PATCH] gitweb: ref markers link to named shortlogs Message-ID: <20080803132050.GA10151@machine.or.cz> In-Reply-To: On Sun, Aug 03, 2008 at 03:14:09PM +0200, Giuseppe Bilotta wrote: > On Sun, Aug 3, 2008 at 2:03 PM, Petr Baudis wrote: > > (ii) I think you should decide on the type of the action based > > on the object type of the ref; actually, any kind of object type can be > > ref'd, and for tags you would rather want tag view, etc. (The tag view > > actually sucks and should behave more like git show tag - i.e. append > > the appropriate view after the tag info - but that is different matter.) > > Funny that. My original plan was to have a different action depending > on tag (I tried shortlog for tag and commitdiff for branch). And since > I I had no idea what kind of action to use for 'generic' refs, I left > them out. Then I had second thoughts and started using shortlog for > both heads and tags, and collapsed the code but still kept the generic > refs out of the way. So maybe we can use shortlog as default action > and single out tags (and whatever else we'll find to need a different > action)? What's wrong with my proposed approach to choose actoin based on object type of the ref? -- Petr "Pasky" Baudis The next generation of interesting software will be done on the Macintosh, not the IBM PC. -- Bill Gates