From: Miklos Vajna Date: Wed, 30 Jul 2008 17:27:02 GMT Subject: Re: [PATCH 4/4] Add a second testcase for handling invalid strategies in git-merge Message-ID: <20080730172702.GG32057@genesis.frugalware.org> In-Reply-To: <7vhca89s02.fsf@gitster.siamese.dyndns.org> On Tue, Jul 29, 2008 at 04:42:53PM -0700, Junio C Hamano wrote: > True, but with the old code that might blindly have executed > git-merge-index the test would also have failed, and you would want to > tell two cases apart, wouldn't you? Hmm, I wonder what is the right approach to test it. Should I exit with a different error code with the strategy is invalid?