From: Shawn O. Pearce Date: Mon, 28 Jul 2008 13:50:00 GMT Subject: Re: [PATCH] Allow building without any git installed Message-ID: <20080728135000.GA3996@spearce.org> In-Reply-To: <7vsktutrh5.fsf@gitster.siamese.dyndns.org> Junio C Hamano wrote: > This is a follow-up patch to 49fa65a (Allow the built-in exec path to be > relative to the command invocation path, 2008-07-23). Without specific > gitexecdir passed from the command line, git-gui's build procedure would > try to figure out the value for it by running an installed git. Ack. I noticed this yesterday while looking at the git Makefile but forgot to send a patch for it myself. Thanks Junio. > diff --git a/Makefile b/Makefile > index 798a2f2..7e30b30 100644 > --- a/Makefile > +++ b/Makefile > @@ -1067,7 +1067,7 @@ endif > > all:: > ifndef NO_TCLTK > - $(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) all > + $(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) gitexecdir='$(gitexec_instdir_SQ)' all > $(QUIET_SUBDIR0)gitk-git $(QUIET_SUBDIR1) all > endif > $(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all -- Shawn.