From: Miklos Vajna <vmiklos@frugalware.org>
Date: Mon, 28 Jul 2008 01:18:28 GMT
Subject: Re: [PATCH 1/7] Make is_git_command() usable outside builtin-help
Message-ID: <20080728011828.GI32057@genesis.frugalware.org>
In-Reply-To: <Pine.GSO.4.62.0807261301300.15728@harper.uchicago.edu>

On Sat, Jul 26, 2008 at 01:12:36PM -0500, Jonathan Nieder <jrnieder@uchicago.edu> wrote:
> On Sat, 26 Jul 2008, Miklos Vajna wrote:
> 
> > +	if (!prefix)
> > +		prefix = "git-";
> > +       	prefix_len = strlen(prefix);
> 
> The whitespace gave me a start: the diff markup moved the prefix_len
> line to the next tab stop, so at first glance it seems there are missing
> braces here.  But it is an illusion.  (I mention this so others might
> avoid wasting time worrying about it.)

In fact it was a whitespace problem: somehow I used spaces there instead
of a tab. I fixed it locally. (Will send an updated series soon.)

> I like the patch so far.  Thanks for the pleasant reading.

:-)