From: Miklos Vajna Date: Sun, 27 Jul 2008 15:28:06 GMT Subject: Re: [RFC/PATCH v2] merge-base: teach "git merge-base" to accept more than 2 arguments Message-ID: <20080727152806.GA32057@genesis.frugalware.org> In-Reply-To: On Sun, Jul 27, 2008 at 04:38:05PM +0200, Johannes Schindelin wrote: > BTW I seem to recall that get_merge_bases_many() was _not_ the same as > get_merge_octopus(). Could you please remind me what _many() does? get_octopus_merge_bases() takes a commit_list, and tries to figure out the common bases of those commits. get_merge_bases_many(), which is used by reduce_heads() takes a commit and a commit_list, and counts the bases of the heads against the commit specified as the first parameter. I think get_merge_bases_many() could be even static, it is not really interesting for anything else than reduce_heads() at the moment.