From: Stephan Beyer Date: Fri, 25 Jul 2008 14:15:17 GMT Subject: Re: [PATCH] editor.c: Libify launch_editor() Message-ID: <20080725141517.GB18198@leksak.fem-net> In-Reply-To: Hi, Johannes Schindelin wrote: > On Fri, 25 Jul 2008, Junio C Hamano wrote: > > Johannes Schindelin writes: > > > > > On Fri, 18 Jul 2008, Stephan Beyer wrote: > > > > > >> diff --git a/editor.c b/editor.c > > >> index 483b62d..5d7f5f9 100644 > > >> --- a/editor.c > > >> +++ b/editor.c > > >> @@ -17,9 +17,8 @@ void launch_editor(const char *path, struct strbuf *buffer, const char *const *e > > > ... > > > Why not "return error()"? > > > > > > Rest looks obviously correct to me! > > > > This is a patch to an existing file editor.c??? > > Yes, Stephan sent the two patches unrelatedly, Yes, because when I've sent 1/2, I didn't knew that 2/2 will exist. So I've just sent the second patch "into this thread" and hoped it would be clear how it is meant. :) So, to summarize: [PATCH 1/2] http://thread.gmane.org/gmane.comp.version-control.git/88940/focus=88940 [PATCH 2/2] http://thread.gmane.org/gmane.comp.version-control.git/88940/focus=89035 They still apply cleanly to current master. > even if they should have been marked "1/2" and "2/2". > I hope he does so now. This means I should send them again? Regards. -- Stephan Beyer , PGP 0x6EDDD207FCC5040F