From: Mike Hommey <mh@glandium.org>
Date: Thu, 24 Jul 2008 16:54:34 GMT
Subject: Re: [PATCH v2] t6030 (bisect): work around Mac OS X "ls"
Message-ID: <20080724165434.GA26660@glandium.org>
In-Reply-To: <Pine.GSO.4.62.0807240233310.27074@harper.uchicago.edu>

On Thu, Jul 24, 2008 at 02:43:51AM -0500, Jonathan Nieder wrote:
> t6030-bisect-porcelain.sh relies on "ls" exiting with nonzero
> status when asked to list nonexistent files.  Unfortunately,
> /bin/ls on Mac OS X 10.3 exits with exit code 0.  So look at
> its output instead.
> 
> Signed-off-by: Jonathan Nieder <jrnieder@uchicago.edu>
> ---
> 
> Mike Hommey wrote:
> 
> > On Thu, Jul 24, 2008 at 07:57:26AM +0200, Christian Couder wrote:
> >> Le jeudi 24 juillet 2008, Jonathan Nieder a �crit :
> >>> -	test_must_fail ls .git/BISECT_* &&
> >>> +	echo .git/BISECT_* | test_must_fail grep BISECT_[^*] &&
> >> 
> >> Perhaps the following is simpler:
> >> 
> >> +	test -z "$(ls .git/BISECT_*)" &&
> > 
> > That is still a useless use of ls ;)
> 
> It is much better than what I wrote, at least.

But could also be written with echo instead of ls.

Mike