From: Alex Riesen Date: Wed, 23 Jul 2008 16:46:14 GMT Subject: Re: [PATCH] Build configuration to skip ctime for modification test Message-ID: <20080723164614.GB5283@blimp.local> In-Reply-To: <7vr69lihkt.fsf@gitster.siamese.dyndns.org> Junio C Hamano, Wed, Jul 23, 2008 02:12:50 +0200: > >> Otherwise, if you really want to tell at compile time,I think for clarity > >> you have to introduce another #define, since NO_TRUSTABLE_FILEMODE > >> definitely says something different than CTIME_IS_USELESS. > > > > I had that at first (NO_DEPENDABLE_CTIME, than IGNORE_CTIME), than > > deemed it excessive. > > Why is it excessive? My initial reaction was "what does trustable > filemode nor trust_executable_bit has anything to do with ctime". Please > explain. Because exactly the file mode (the executable bit) is the reason for checking ctime. Otherwise there is no point: Git doesn't save any other data which when changed cause a ctime update. And exactly the file mode is completely broken on that cygwin thing. Which is precisely pointed by NO_TRUSTABLE_FILEMODE. Hence - just it.