From: Jeff King Date: Tue, 22 Jul 2008 07:16:30 GMT Subject: Re: [PATCH 2/2] spawn pager via run_command interface Message-ID: <20080722071630.GA3669@sigill.intra.peff.net> In-Reply-To: <20080722071411.GB3584@sigill.intra.peff.net> On Tue, Jul 22, 2008 at 03:14:12AM -0400, Jeff King wrote: > static struct child_process pager_process = { > .argv = pager_argv, > - .in = -1 > + .in = -1, > +#ifndef __MINGW32__ > + .preexec_cb = pager_preexec, > +#endif I couldn't recall if this initializer style is portable enough for us. It was already there wrapped in ifdefs, but perhaps it was only ok because the mingw version always uses the same compiler? -Peff