From: Jeff King <peff@peff.net>
Date: Wed, 16 Jul 2008 05:18:29 GMT
Subject: Re: [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only
Message-ID: <20080716051829.GB4030@segfault.peff.net>
In-Reply-To: <1215877672-17049-1-git-send-email-s-beyer@gmx.net>

On Sat, Jul 12, 2008 at 05:47:51PM +0200, Stephan Beyer wrote:

> The test_must_fail function in test-lib.sh has been designed
> to distinguish segmentation faults from controlled errors.
> But in the current implementation this only works if a git
> command does not return a small negative value, like -1, -2
> or -3. But some git commands do.

This is probably a fine protective measure, and it looks like Junio has
already applied it. But shouldn't any git commands returning such values
be fixed? Which commands return such bogus error codes?

-Peff