From: Shawn O. Pearce <spearce@spearce.org>
Date: Tue, 15 Jul 2008 03:18:00 GMT
Subject: Re: [PATCH 4/4] index-pack: Honor core.deltaBaseCacheLimit when resolving deltas
Message-ID: <20080715031800.GD1700@spearce.org>
In-Reply-To: <alpine.LFD.1.10.0807142255240.12484@xanadu.home>

Nicolas Pitre <nico@cam.org> wrote:
> On Sun, 13 Jul 2008, Shawn O. Pearce wrote:
> 
> But this patch is suboptimal as it actually recreate the same memory 
> pressure, to a lesser degree, this series is meant to solve.  If you do:

Arrgh.  Good catch on review.  I'll post a replacement patch shortly
that doesn't suffer from this problem.  Thanks!
 
> > +		struct object_entry *obj = c->obj;
> > +		void *raw = get_data_from_pack(obj);
> > +		if (obj->type == OBJ_REF_DELTA || obj->type == OBJ_OFS_DELTA) {
> > +			c->data = patch_delta(
> > +				get_base_data(c->base), c->base->size,
> > +				raw, obj->size,
> > +				&c->size);
> > +			free(raw);

-- 
Shawn.