From: Shawn O. Pearce Date: Sun, 13 Jul 2008 22:06:31 GMT Subject: Re: [PATCH] bash completion: Fix the . -> .. revision range completion Message-ID: <20080713220631.GB12708@spearce.org> In-Reply-To: <7vskudpiqq.fsf@gitster.siamese.dyndns.org> Junio C Hamano wrote: > Petr Baudis writes: > > When Git sees a string with trailing dot on a place where revision > > range could occur, it will unconditionally append another dot to ... > > git log git-submodule. ... > By the way, the above command line is another "dot" related frustration I > always have. If you try: > > git log v1.5.6. > > the completion code adds a dot unconditionally when I want to choose from > the list of v1.5.6.X tags. This annoys me too Junio. Its a bug I just never got around to fixing. Based on Petr's comments and yours I'm wondering if this is just not the better patch to apply here: --8<-- bash completion: Don't offer "a.." as a completion for "a." If the user is trying to complete "v1.5.3." to see all of the available maintenance releases for 1.5.3 we should not give them an extra dot as the completion. Instead if the user wants a ".." or a "..." operator they should key the two dots out on their own. Its the same number of keystrokes either way. Signed-off-by: Shawn O. Pearce --- contrib/completion/git-completion.bash | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 61581fe..9a1c66a 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -324,9 +324,6 @@ __git_complete_revlist () cur="${cur#*..}" __gitcomp "$(__git_refs)" "$pfx" "$cur" ;; - *.) - __gitcomp "$cur." - ;; *) __gitcomp "$(__git_refs)" ;; -- 1.5.6.2.393.g45096 -- Shawn.