From: Johannes Sixt <johannes.sixt@telecom.at>
Date: Wed, 02 Jul 2008 18:43:43 GMT
Subject: Re: [PATCH 01/12] Fake reencoding success under NO_ICONV instead of returning NULL.
Message-ID: <200807022043.43260.johannes.sixt@telecom.at>
In-Reply-To: <1214987532-23640-1-git-send-email-prohaska@zib.de>


On Mittwoch, 2. Juli 2008, Steffen Prohaska wrote:
> From: Johannes Sixt <johannes.sixt@telecom.at>
>
> git-am when invoked from git-rebase seems to rely on successful conversion.

> diff --git a/utf8.h b/utf8.h
> index 98cce1b..f22ef31 100644
> --- a/utf8.h
> +++ b/utf8.h
> @@ -10,10 +10,6 @@ int is_encoding_utf8(const char *name);
>
>  int print_wrapped_text(const char *text, int indent, int indent2, int
> len);
>
> -#ifndef NO_ICONV
>  char *reencode_string(const char *in, const char *out_encoding, const char
> *in_encoding); -#else
> -#define reencode_string(a,b,c) NULL
> -#endif
>
>  #endif

I don't think that this is still needed. It dates back to the origins of 
mingw.git, at which time I did not have a working libiconv.

-- Hannes