From: Shawn O. Pearce Date: Sun, 29 Jun 2008 18:06:55 GMT Subject: Re: [JGIT PATCH 16/21] Add Robert Harder's public domain Base64 encoding utility Message-ID: <20080629180655.GH11793@spearce.org> In-Reply-To: <200806291551.08166.robin.rosenberg@dewire.com> Robin Rosenberg wrote: > > Dragging in apache commons libraries seems to be too much at this > point, one class, so this choice is understandable at this point. > > Other that that Apache Commons are almost ubiquotous these days > and so be considered at every point when we need external code. True. But I have a nearly allergic reaction to Apache code; for some reason its always sort of not quite there. Which also describes jgit so I shouldn't say anything. ;-) We can always rip this implementation out if we do wind up taking in the Apache Commons libraries for other support. There is only 1 or two calls sites and it should be easy enough to change over to the Apache Commons implementation. -- Shawn.