From: Pierre Habouzit Date: Thu, 26 Jun 2008 21:33:04 GMT Subject: Re: [PATCH 1/2] Introduce leaky(). Message-ID: <20080626213304.GA22111@artemis.madism.org> In-Reply-To: <7vbq1oqbjg.fsf@gitster.siamese.dyndns.org> On Thu, Jun 26, 2008 at 06:46:43PM +0000, Junio C Hamano wrote: > The user would also need to worry about not freeing the original > allocation pointer when something is realloc(3)ed, which means either > finding the last realloc(3) of the object (that is logically the same, but > just being extended) and mark the pointer as leaky() after that realloc, > or unregister the original pointer from leaks before calling realloc and > register what comes back. It will easily get messy. Hmm indeed, maybe it isn't such a good idea then. > By the way, the series queued in your repository still has "s/pring/print/" > typo in 4/7 and "argv not NULL terminated" comment in 6/7. I'll fix that and pushed again, without the leaky() series dependency (I've put in a comment that I'm aware that it's a leak), and with the two fixes you mention done. -- ·O· Pierre Habouzit ··O madcoder@debian.org OOO http://www.madism.org