From: Pierre Habouzit <madcoder@debian.org>
Date: Tue, 24 Jun 2008 22:10:48 GMT
Subject: Re: [PATCH 1/2] Introduce leaky().
Message-ID: <20080624221048.GI9189@artemis.madism.org>
In-Reply-To: <m3skv2jzey.fsf@localhost.localdomain>

On Tue, Jun 24, 2008 at 09:28:30PM +0000, Jakub Narebski wrote:
> Pierre Habouzit <madcoder@debian.org> writes:
> 
> > diff --git a/Makefile b/Makefile
> 
> > +#
> > +# Define COLLECT_LEAKS_AT_EXIT if you want memory marked as leaky() at exit.
> 
> I think s/at exit/to be freed &/;

  err obviously.

> > diff --git a/cache.h b/cache.h
> 
> Hmmm... cache?

  well cache.h has the prototypes for alloc.c that feels like the proper
place, but I don't care much :)

> >  /* alloc.c */
> > +#ifdef COLLECT_LEAKS_AT_EXIT
> > +extern void *leaky(void *);
> > +#else
> > +# define leaky(x) x
> > +#endif
> 
> Not 
> 
> +# define leaky(x) (x)
> 
> to be careful?

ack.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org