From: Karl Hasselström <kha@treskal.com>
Date: Sun, 22 Jun 2008 16:13:41 GMT
Subject: Re: [StGIT PATCH 4/4] Remove the applied/unapplied commands
Message-ID: <20080622161341.GD4468@diana.vm.bytemark.co.uk>
In-Reply-To: <20080619214233.27794.98487.stgit@localhost.localdomain>

On 2008-06-19 22:42:33 +0100, Catalin Marinas wrote:

> This patch moves the applied/unapplied functionality to the 'series'
> command via the corresponding options.

Nice.

>             make_option('-a', '--all',
>                         help = 'show all patches, including the hidden ones',
>                         action = 'store_true'),
> +           make_option('--applied',
> +                       help = 'show the applied patches only',
> +                       action = 'store_true'),
> +           make_option('--unapplied',
> +                       help = 'show the unapplied patches only',
> +                       action = 'store_true'),
>             make_option('--hidden',
>                         help = 'show the hidden patches only',
>                         action = 'store_true'),

Maybe some logic to prohibit the use of more than one of these at
once? The current logic is kind of arbitrary.

Also, we should perhaps invent good single-letter abbreviations for
these presumably rather common flags. -a is taken; -A and -U perhaps?

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle