From: Shawn O. Pearce Date: Sat, 21 Jun 2008 03:21:32 GMT Subject: Re: [PATCH] git-gui: Fix accidental staged state toggle when clicking top pixel row Message-ID: <20080621032132.GW11793@spearce.org> In-Reply-To: <1213973895-10264-1-git-send-email-richard.quirk@gmail.com> Richard Quirk wrote: > If a text widget is asked the index at x,y with y == 0 or y == 1 it will > always return 1.0 as the nearest index, regardless of the x position. > > This means that clicking the top 2 pixels of the Unstaged/Staged Changes > lists caused the state of the file there to be toggled. This patch > checks that the pixel clicked is greater than 1, so there is less chance > of accidentally staging or unstaging changes. Thanks. Its in my master branch now. -- Shawn.