From: Adam Simpkins <adam@adamsimpkins.net>
Date: Fri, 20 Jun 2008 06:00:37 GMT
Subject: Re: [PATCH] graph.c: make many functions static
Message-ID: <20080620060035.GA22345@adamsimpkins.net>
In-Reply-To: <7vhcbptev8.fsf@gitster.siamese.dyndns.org>

On Thu, Jun 19, 2008 at 12:16:11PM -0700, Junio C Hamano wrote:
> しらいしななこ  <nanako3@lavabit.com> writes:
> 
> > ---
> >  graph.c |   57 +++++++++++++++++++++++++++++++++++++++++++--------------
> >  graph.h |   40 ----------------------------------------
> >  2 files changed, 43 insertions(+), 54 deletions(-)
> >
> > diff --git a/graph.c b/graph.c
> > index e2633f8..5f82170 100644
> > --- a/graph.c
> > +++ b/graph.c
> > @@ -4,6 +4,43 @@
> >  #include "diff.h"
> >  #include "revision.h"
> >  
> > +/* Internal API */
> > + ...
> > +static int graph_next_line(struct git_graph *graph, struct strbuf *sb);
> > +static void graph_padding_line(struct git_graph *graph, struct strbuf *sb);
> > +static void graph_show_strbuf(struct git_graph *graph, struct strbuf const *sb);
> 
> I think these are probably fine, not in the sense that nobody calls these
> functions _right now_ but in the sense that I do not foresee a calling
> sequence outside the graph.c internal that needs to call these directly,
> instead of calling graph_show_*() functions that use these.

Documentation/technical/api-history-graph.txt should also be updated
to remove the discussion of these functions if they are no longer
publicly exposed.

-- 
Adam Simpkins
adam@adamsimpkins.net