From: Mike Hommey <mh@glandium.org>
Date: Thu, 19 Jun 2008 17:56:39 GMT
Subject: Re: [PATCH] t7502-commit.sh: test_must_fail doesn't work with inline environment variables
Message-ID: <20080619175639.GA1604@glandium.org>
In-Reply-To: <gASAIyn4TvarEmVo9rWtEKa6eROfKXwowHxH6j05FzPARJ-CDBCHLw@cipher.nrlssc.navy.mil>

On Thu, Jun 19, 2008 at 12:44:23PM -0500, Brandon Casey wrote:
> Mike Hommey wrote:
> > On Thu, Jun 19, 2008 at 12:32:02PM -0500, Brandon Casey wrote:
> >> -	test_must_fail GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" git commit &&
> >> +	# We intentionally do not use test_must_fail on the next line since the
> >> +	# mechanism does not work when setting environment variables inline
> >> +	! GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" git commit &&
> > 
> > Doesn't GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" test_must_fail git commit
> > work ?
> 
> That leaves GIT_EDITOR set to the new value after the command completes.

It really shouldn't.

Mike