From: Mike Hommey <mh@glandium.org>
Date: Thu, 19 Jun 2008 17:39:32 GMT
Subject: Re: [PATCH] t7502-commit.sh: test_must_fail doesn't work with inline environment variables
Message-ID: <20080619173932.GA32593@glandium.org>
In-Reply-To: <JvISWq5uUteLVQOl-3QkroLV8SsQufGuWrfseMUjpYY@cipher.nrlssc.navy.mil>

On Thu, Jun 19, 2008 at 12:32:02PM -0500, Brandon Casey wrote:
> -	test_must_fail GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" git commit &&
> +	# We intentionally do not use test_must_fail on the next line since the
> +	# mechanism does not work when setting environment variables inline
> +	! GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" git commit &&

Doesn't GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" test_must_fail git commit
work ?

Mike