From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Tue, 17 Jun 2008 22:07:00 GMT
Subject: Re: [EGIT PATCH 21/20] Make isBetterDeltaReuseLoader() static in PackWriter
Message-ID: <200806180007.01061.robin.rosenberg.lists@dewire.com>
In-Reply-To: <1213738134-6221-1-git-send-email-marek.zawirski@gmail.com>

tisdagen den 17 juni 2008 23.28.54 skrev Marek Zawirski:
> Implementation was already static, it's just a fix for clarity and
> potential speed-up.
> 
> Reported-by: Shawn O. Pearce <spearce@spearce.org>
> Signed-off-by: Marek Zawirski <marek.zawirski@gmail.com>
> ---
> It could be squashed with patch 19/20. I can clean up this mess, adding 
> also Shawn's patch - just let me know what is preferred way (squash
> commits, commits on top?).

If the code is already merged then patch on top, else squashing or rebase,
unless you feel there is a reason not to. We can pretend it was right from
the start :)  I see no educational value in having a separate patch in this case.

-- robin