From: Don Zickus <dzickus@redhat.com>
Date: Tue, 17 Jun 2008 14:14:52 GMT
Subject: Re: [PATCH] git-apply doesn't handle same name patches well [V2]
Message-ID: <20080617141452.GJ16941@redhat.com>
In-Reply-To: <alpine.DEB.1.00.0806171027200.6439@racer>

On Tue, Jun 17, 2008 at 10:30:35AM +0100, Johannes Schindelin wrote:
> Hi,
> 
> On Mon, 16 Jun 2008, Don Zickus wrote:
> 
> > Changes since v1
> > ================
> > - converted to path-list structs
> > - added testcases for renaming a patch and apply a new patch on top inside
> > the same patch file
> 
> Just for future reference: commonly, this is not put into the commit 
> message, but after the "---" separator into the mail comments.

Ok. Thanks.

> 
> > +/*
> > + * Caches patch filenames to handle the case where a
> > + * patch chunk reuses a filename
> > + */
> > +struct fn_cache {
> > +	char *name;
> > +	struct patch *patch;
> > +	struct fn_cache *next;
> > +};
> 
> It is still not a path_list.  Even if you said so in the "Changes since 
> V1".

Yeah, I attached the wrong patch, see V3. :-)

Cheers,
Don