From: Jeff King Date: Fri, 13 Jun 2008 13:11:09 GMT Subject: Re: [PATCH 2/2] git-gc: skip stashes when expiring reflogs Message-ID: <20080613131108.GA15876@sigill.intra.peff.net> In-Reply-To: <19C06D62-966A-4626-A620-2281A7CAA2B6@wincent.com> On Fri, Jun 13, 2008 at 02:40:50PM +0200, Wincent Colaiuta wrote: > Sounds a little bit over-engineered to me. > > So, "stash" is intended for short-term storage, but by adding a "keep" > option you're officially blessing it for long-term storage as well. And > the interface that you propose, explicitly marking stuff as "for keeps" > and being able to move stuff from "temp" to "keep" sounds quite > complicated. I agree. I like the expiration of stashes, but if it is a choice between "just don't expire them" and "here is a complex set of rules and obligations for preventing them from expiring" I think we are better off just leaving them. -Peff