From: Robin Rosenberg Date: Tue, 10 Jun 2008 06:29:50 GMT Subject: Re: [EGIT PATCHES] Assorted minor fixes Message-ID: <200806100829.50793.robin.rosenberg.lists@dewire.com> In-Reply-To: <20080610003144.GD4389@spearce.org> tisdagen den 10 juni 2008 02.31.44 skrev Shawn O. Pearce: > How did you you send this series? Its not format-patch output. > The diff-stat is missing from each commit, and there's no --- > to split message from diff. I didn't bother trying to run them > through git-am yet as I assume I can just fetch from you, I'm > just saying the patches look "odd". It was git format-patch --binary. Seems that option drops the diffstat in that case. Yes you can just pull and get the same series. I mostly sent it as patches for review purposes. It is much easier in e-mail. Using gtik for reviiew isn't optimal. A nice tool for reviewing and commenting directly from a repo would be nice. -- robin