From: Johan Herland <johan@herland.net>
Date: Mon, 09 Jun 2008 05:46:22 GMT
Subject: Re: [PATCH v3] git-add--interactive: manual hunk editing mode
Message-ID: <200806090746.22512.johan@herland.net>
In-Reply-To: <alpine.DEB.1.00.0806090018350.1783@racer>

On Monday 09 June 2008, Johannes Schindelin wrote:
> Hi,
>
> On Mon, 9 Jun 2008, Thomas Rast wrote:
> > Compared to the competing bikeshed
> >   http://article.gmane.org/gmane.comp.version-control.git/83894
>
> If you really think this is a bikeshed, I better spend my time elsewhere.

Is there a good reason against having *both*?

AFAICS, there's nothing stopping us from having both a "-e"-option to 
git-add, and an "e"-command inside git-add--interactive.

...just like we have "-p" and "p" today...

("git-add -e" would open the entire diff in an editor, as would "e" from the 
*main* menu of git-add--interactive. However, "e" from the *single hunk* 
menu would of course open only that single hunk within the editor. We could 
even have an "E" command to open all remaining/undecided hunks in an 
editor.)


Have fun! :)

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net