From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Sun, 08 Jun 2008 21:05:26 GMT
Subject: Re: [JGIT PATCH v3 20/23] Added the class NoGitRepositoryFoundException.
Message-ID: <200806082305.30035.robin.rosenberg.lists@dewire.com>
In-Reply-To: <484C0548.8090309@web.de>

söndagen den 8 juni 2008 18.14.00 skrev Florian Köberle:
> Robin Rosenberg wrote:
>  >> +		super(String.format("No repository found for file '%s'",
>  >> +				fileWeSearchedRepositoryFor));
>  >
>  > This is any odd patterrn. Usually we use + to concatenate strimgs.
> 
> Hi Robin,
> 
> I know two good reason why you should use formating functions over 
> string concatenation via the plus sign:
> 
> 1.) formated strings are better translatable. e.g.
> "The string '%s' is more then %s characters long"
[..]
> 2.) Whitespace mistakes are easier to see. e.g.
> (i + "coins") and ("%scoins", i)
> 
> Sure you can make the mistake to provide not enough arguments, but 
> that's not so worse:
> a.) Some IDEs, like Intellij IDEA warn you if you call a formating 
> function with to few arguments.

I'm so ashamed... I used to like printf in C, but I've hardly used it in Java. I
probably will use it more now. Seems Eclipse doesn't check (even GCC
does that).

-- robin