From: Miklos Vajna Date: Sat, 07 Jun 2008 02:03:26 GMT Subject: Re: [PATCH 08/10] Introduce commit_list_append() in commit.c Message-ID: <20080607020326.GB29404@genesis.frugalware.org> In-Reply-To: <7viqwmqexg.fsf@gitster.siamese.dyndns.org> On Fri, Jun 06, 2008 at 05:14:35PM -0700, Junio C Hamano wrote: > If that is the case, you might want to check how parse_commit_buffer() in > commit.c builds "parents" list. It is a standard pattern to append to the > list using commit_list_insert() and that is the reason why it returns a > pointer. Ah, great, then this patch is not necessary. I removed it from my working branch. Thanks.