From: Miklos Vajna Date: Fri, 06 Jun 2008 23:52:39 GMT Subject: Re: [PATCH 08/10] Introduce commit_list_append() in commit.c Message-ID: <20080606235239.GY29404@genesis.frugalware.org> In-Reply-To: <7v8wxjzd41.fsf@gitster.siamese.dyndns.org> On Thu, Jun 05, 2008 at 04:16:46PM -0700, Junio C Hamano wrote: > Do you have a caller of this function that keeps a pointer to commit_list > that needs to be appended at the tail or inserted at the beginning > depending on the phase of the moon, or does the caller always append to > that list? The later. I use it for appending a new parent for the merge commit and after parsing a new remote head. In both cases I always append a list.