From: Jeff King Date: Wed, 04 Jun 2008 00:35:16 GMT Subject: Re: Octopus merge: unique (?) to git, but is it useful? Message-ID: <20080604003516.GA24232@sigill.intra.peff.net> In-Reply-To: <20080603231020.GB6588@neumann> On Wed, Jun 04, 2008 at 01:10:20AM +0200, SZEDER Gábor wrote: > Yes, the first hunk fixes the problem (and the second one does not > introduce any new breakage on my system ;) > > However, I don't really see why the new test failed only at me... Because you were the only person (so far) whose gecos information wasn't sufficient for git-commit to work. In Junio's case, the test script accidentally unset the GIT_COMMITTER_{NAME,EMAIL} variables, which caused git-commit to fall back on the information in /etc/passwd; it worked, but it was doing something unintended. On your system, that information wasn't available, so git-commit just broke. -Peff