From: Mike Hommey <mh@glandium.org>
Date: Tue, 27 May 2008 16:30:27 GMT
Subject: Re: [PATCH] clone: make sure we support the transport type
Message-ID: <20080527163027.GB11865@glandium.org>
In-Reply-To: <20080527142842.GA7651@sigill.intra.peff.net>

On Tue, May 27, 2008 at 10:28:43AM -0400, Jeff King wrote:
> If we use an unsupported transport (e.g., http when curl
> support is not compiled in), transport_get reports an error
> to the user, but we still get a transport object. We need to
> manually check and abort the clone process at that point, or
> we end up with a segfault.

Shouldn't transport_get return NULL in such a situation, instead ?

Mike