From: Johan Herland Date: Thu, 22 May 2008 22:34:33 GMT Subject: Re: [PATCH] Add a test for another combination of --reference Message-ID: <200805230034.33567.johan@herland.net> In-Reply-To: On Friday 23 May 2008, Daniel Barkalow wrote: > From: Johan Herland > > In this case, the reference repository has some useful loose objects, > but not all useful objects, and we make sure that we can find the > objects we fetch from the repository we're cloning in the new > repository, instead of potentially being distracted by the reference > repository. > > Doing the wrong thing in a builtin-clone implementation would lead to > this looking for an object in the wrong place, not finding it (because > it's only in the right place), and crashing. > > Signed-off-by: Johan Herland > Signed-off-by: Daniel Barkalow Thanks again. ...Johan PS: I'm holding off on submitting my builtin-clone-packs-refs series until 1.5.6 is out. I think builtin-clone has seen enough action in this cycle. :) -- Johan Herland, www.herland.net