From: Heikki Orsila <shd@modeemi.fi>
Date: Wed, 21 May 2008 23:27:35 GMT
Subject: Re: [PATCH] Add format.date config variable
Message-ID: <20080521232735.GB10527@jolt.modeemi.cs.tut.fi>
In-Reply-To: <7vtzgr347p.fsf@gitster.siamese.dyndns.org>

On Wed, May 21, 2008 at 11:24:42AM -0700, Junio C Hamano wrote:
> > Also, add missing "short" alternative to --date in rev-list-options.txt.
> 
> Good change but is a separate issue.  Please make it a [PATCH 1/2].

Will do that a separate patch.

> Lacking Sign-off.

OK. Thanks.

> The patch itself is good, especially that you made sure that format-patch
> output is not affected.
> 
> As to the configuration variable name, I'd suggest "log.date" instead.

OK.

Will submit a patch later today.

-- 
Heikki Orsila
heikki.orsila@iki.fi
http://www.iki.fi/shd