From: Shawn O. Pearce <spearce@spearce.org>
Date: Mon, 12 May 2008 23:54:31 GMT
Subject: Re: [JGIT PATCH v2 04/24] Added path related constats to Constats class.
Message-ID: <20080512235431.GY29038@spearce.org>
In-Reply-To: <1210623222-24908-5-git-send-email-florianskarten@web.de>

Florian Koeberle <florianskarten@web.de> wrote:
> @@ -171,6 +171,26 @@ public final class Constants {
>  	public static String REMOTES_PREFIX = "refs/remotes";
>  
>  	/**
> +	 * The name of the repository directory in the project directory.
> +	 */
> +	public static final String REPOSITORY_DIRECTORY_NAME = ".git";

What is a project directory?

> +	/**
> +	 * Contains the name of the HEAD file in the repository directory.
> +	 */
> +	public static final String HEAD_FILE_NAME = "HEAD";

Isn't this already declared as just HEAD?  Lets not duplicate
constants if we can avoid it, especially when they are in the
same class.

-- 
Shawn.