From: Michele Ballabio <barra_cuda@katamail.com>
Date: Fri, 02 May 2008 14:56:57 GMT
Subject: Re: [PATCH] gitk: disable "Reset %s branch to here" when on a detached head
Message-ID: <200805021656.57929.barra_cuda@katamail.com>
In-Reply-To: <18459.3700.934377.597975@cargo.ozlabs.ibm.com>

On Friday 02 May 2008, Paul Mackerras wrote:
> > -     $menu entryconfigure 7 -label [mc "Reset %s branch to here" $mainhead]
> > +     if {$mainhead ne {}} {
> > +         $menu entryconfigure 7 -label [mc "Reset %s branch to here" $mainhead]
> > +     } else {
> > +         $menu entryconfigure 7 -label [mc "Reset %s branch to here" $mainhead] -state disabled
> 
> I wonder if we can make this message something more appropriate than
> "Reset  branch to here" (since $mainhead has to be the empty string
> here)?  Not sure what I would suggest though. :)

Oh, you're right. I'd say either "Reset detached head to here" greyed out
(i.e. change the words as little as possible), or something more
explicative like "Detached head: reset not possible". I'd go for the first,
but I'm really not sure about this: you'd better seek suggestions from a
native speaker :).