From: Jeff King <peff@peff.net>
Date: Wed, 30 Apr 2008 03:31:46 GMT
Subject: Re: cvsimport and branches with "(" in the name
Message-ID: <20080430033146.GA28373@sigill.intra.peff.net>
In-Reply-To: <118833cc0804291745m2da2a3bdl21a9440e961afb6@mail.gmail.com>

On Tue, Apr 29, 2008 at 08:45:42PM -0400, Morten Welinder wrote:

> >  -       system("git-update-ref $remote/$branch $cid") == 0
> >  +       system('git-update-ref', "$remote/$branch", $cid) == 0
> 
> I hope there are no further such system calls left.  This could run arbitrary
> commands if one was tricked into importing an evil repository.

Yes, even if that doesn't fix his problem, it should still be changed. I
have confirmed that it's the only such one in git-cvsimport.

-Peff