From: Mike Hommey <mh@glandium.org>
Date: Mon, 28 Apr 2008 18:29:17 GMT
Subject: Re: [PATCH] git-daemon: fix for rotating logs
Message-ID: <20080428182917.GA4794@glandium.org>
In-Reply-To: <20080428182114.GF26880@genesis.frugalware.org>

On Mon, Apr 28, 2008 at 08:21:14PM +0200, Miklos Vajna wrote:
> On Mon, Apr 28, 2008 at 07:08:50PM +0100, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > > > With rotating logs, there is a problem when the syslog is opened only 
> > > > once (in the beginning).  So open the log everytime we write 
> > > > something, and close it directly after writing.
> > > 
> > > Gaah, this is ugly.
> > > 
> > > Is this something all the daemons need to deal with?
> > 
> > I have no idea, but it seems to fix a real issue.
> 
> logrotate supports sending a signal (typically SIGHUP) to the process
> after it rotated the log. Couldn't we just re-open the log on SIGHUP?

Isn't the problem that git-daemon loses its connection to the syslog
daemon when logrotate sighups syslog?

Mike