From: Shawn O. Pearce <spearce@spearce.org>
Date: Sun, 27 Apr 2008 04:18:16 GMT
Subject: Re: [PATCH] bash: Add completion for gitk --merge
Message-ID: <20080427041816.GH29771@spearce.org>
In-Reply-To: <1209252734-10861-1-git-send-email-richard.quirk@gmail.com>

Richard Quirk <richard.quirk@gmail.com> wrote:
> Option is only completed when .git/MERGE_HEAD is present.
> 
> Signed-off-by: Richard Quirk <richard.quirk@gmail.com>
> ---
>  contrib/completion/git-completion.bash |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)

Nice.
 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 665a895..2565aa6 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1346,9 +1346,14 @@ _git ()
>  _gitk ()
>  {
>  	local cur="${COMP_WORDS[COMP_CWORD]}"
> +	local g="$(git rev-parse --git-dir 2>/dev/null)"
> +	local merge=""
> +	if [ -f $g/MERGE_HEAD ]; then
> +		local merge="--merge"

I don't think the extra "local" is necessary within the if block;
you have already declared it to be local when you initialized it
to the empty string.

-- 
Shawn.