From: Stephen R. van den Berg Date: Sat, 26 Apr 2008 11:59:56 GMT Subject: Re: [PATCH] Simplify and fix --first-parent implementation Message-ID: <20080426115956.GB19558@cuci.nl> In-Reply-To: <7viqy5o4om.fsf@gitster.siamese.dyndns.org> Junio C Hamano wrote: >"Stephen R. van den Berg" writes: >> --- >No explanation of what the patch does, nor justification of why it is a >good change? Sorry, thought that one-line description was enough. I'll resubmit this one more verbosely. >Please also sign your patch. Just with git-commit -s ? Or do I need to get gpg involved? >The original code makes sure all the parents of the given commits are >marked as SEEN (and SYMMETRIC_LEFT if needed), even when only it traverses >the first parent. By leaving the loop early, you are changing the >semantics of the code. Other parents, when reached from other paths while >traversing the commit ancestry chain, will behave differently between the >version with your patch and without. Yes, I was and am aware of that. The previous behaviour appears to be bogus. I'll elaborate on resubmission. P.S. No reaction on the other patches means that they're accepted, or do I need to resubmit them as well (signed)? -- Sincerely, srb@cuci.nl Stephen R. van den Berg.