From: Jeff King <peff@peff.net>
Date: Thu, 24 Apr 2008 01:33:00 GMT
Subject: Re: [PATCH 1/3 v2] Add --blob-filter option to filter-branch.
Message-ID: <20080424013259.GA31146@sigill.intra.peff.net>
In-Reply-To: <32541b130804231507l4aff2ca3x962bf385a409685b@mail.gmail.com>

On Wed, Apr 23, 2008 at 06:07:03PM -0400, Avery Pennarun wrote:

> I think it would be fine to index into the cache using $path$sha1,
> which would seem to resolve this issue.  The catch is that $path isn't
> a very good cachefile name.  I'd suggest doing an md5sum or something
> on it, but that would result in an extra fork for every file, which
> brings us back to our original level of slowness (or worse).
> 
> Hmm, I gues using a cachefile like $sha1/$path would work; it requires
> a "mkdir -p", but only when *filling* the cache.

Keep in mind that $path can have slashes. So you actually need to:

   mkdir -p `dirname $sha1/$path`
   echo $new >$sha1/$path

-Peff