From: Jeff King <peff@peff.net>
Date: Wed, 23 Apr 2008 21:55:01 GMT
Subject: Re: [PATCH 1/3 v2] Add --blob-filter option to filter-branch.
Message-ID: <20080423215501.GB30057@sigill.intra.peff.net>
In-Reply-To: <1208981890-758-1-git-send-email-apenwarr@gmail.com>

On Wed, Apr 23, 2008 at 04:18:10PM -0400, Avery Pennarun wrote:

> From: Jeff King <peff@peff.net>
> 
> This patch allows
> 
>   git filter-branch --blob-filter 'tr a-z A-Z'

The commit message munging you did is fine.

However, I think Johannes Sixt's question about providing the pathname
needs to be resolved. As it is now, the blob-filter is impossible to use
in a mixed binary/text repository, short of the undocumented $path magic
that you described. And I am a little uncomfortable just adding the
$path as he suggested because of the subtle bug it introduces.

-Peff