From: Eric Wong <normalperson@yhbt.net>
Date: Thu, 17 Apr 2008 04:36:20 GMT
Subject: Re: [PATCH 2/3] git-svn: Add --add-author-from option.
Message-ID: <20080417043620.GA11600@soma>
In-Reply-To: <1208307858-31039-2-git-send-email-apenwarr@gmail.com>

apenwarr@gmail.com wrote:
> From: Avery Pennarun <apenwarr@versabanq.com>
> 
> This adds a From: line (based on the commit's author information) when
> sending to svn.  It doesn't add if a From: or Signed-off-by: header already
> exists for that commit.
> 
> This, combined with --use-log-author, can retain the author field of commits
> through a round trip from git to svn and back.
> Signed-off-by: Avery Pennarun <apenwarr@gmail.com>

This seems like a useful feature for SVN projects and I've sometimes
wanted it myself.  Thanks.

One thing, can you add some tests to ensure this continues working?  I
don't have lots of time to work on git-svn these days and if I do, I
want it to be easy to ensure I'm not breaking things :)

Thanks.

-- 
Eric Wong